| To: | Chandra Seetharaman <sekharan@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 24 Jul 2011 07:39:59 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20110722233945.14612.1955.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20110722233933.14612.65879.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110722233945.14612.1955.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> @@ -1247,6 +1247,7 @@ xlog_bdstrat(
> {
> struct xlog_in_core *iclog = bp->b_fspriv;
>
> + bp->b_flags &= ~(XBF_FUA|XBF_FLUSH);
I don't think this is correct, we set these before calling into
xlog_bdstrat, so this means we'll always stip it off after that.
Given that this area is more complicated than the pure macro removal
how about letting it as-is for now? I have some bigger refactoring
in this area in my queue, and I'll just incorporate the
XFS_BUF_ZEROFLAGS into it.
|
| Previous by Date: | Re: [PATCH 12/12] xfs: Remove the macro XFS_BUFTARG_NAME, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 03/12 v3] xfs: Remove the macro XFS_BUF_ERROR and family, Christoph Hellwig |
| Previous by Thread: | [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS, Chandra Seetharaman |
| Next by Thread: | Re: [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS, Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |