Re: [PATCH 07/12] xfs: Remove the macro XFS_BUF

To:	Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject:	Re: [PATCH 07/12] xfs: Remove the macro XFS_BUF_PTR
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sat, 16 Jul 2011 13:03:52 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20110716012147.6629.12496.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References:	<20110716012105.6629.24407.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110716012147.6629.12496.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

> -                     memcpy((char *)dabuf->data + off, XFS_BUF_PTR(bp),
> +                     memcpy((char *)dabuf->data + off, bp->b_addr,
>                               XFS_BUF_COUNT(bp));
>               }
>       }
> @@ -2317,7 +2317,7 @@ xfs_da_buf_clean(xfs_dabuf_t *dabuf)
>               for (i = off = 0; i < dabuf->nbuf;
>                               i++, off += XFS_BUF_COUNT(bp)) {
>                       bp = dabuf->bps[i];
> -                     memcpy(XFS_BUF_PTR(bp), (char *)dabuf->data + off,
> +                     memcpy(bp->b_addr, (char *)dabuf->data + off,
>                               XFS_BUF_COUNT(bp));

While not strictly related it would be nice to kill tha (char *) casts
here while you're at it.

Otherwise the patch looks go,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 12/12] xfs: Remove the macro XFS_BUFTARG_NAME, (continued) Re: [PATCH 12/12] xfs: Remove the macro XFS_BUFTARG_NAME, Christoph Hellwig [PATCH 02/12] xfs: Remove the macro XFS_BUF_ZEROFLAGS, Chandra Seetharaman Re: [PATCH 02/12] xfs: Remove the macro XFS_BUF_ZEROFLAGS, Christoph Hellwig Re: [PATCH 02/12] xfs: Remove the macro XFS_BUF_ZEROFLAGS, Chandra Seetharaman Re: [PATCH 02/12] xfs: Remove the macro XFS_BUF_ZEROFLAGS, Christoph Hellwig [PATCH 03/12] xfs: Remove the macro XFS_BUF_ERROR and family, Chandra Seetharaman Re: [PATCH 03/12] xfs: Remove the macro XFS_BUF_ERROR and family, Christoph Hellwig [PATCH 06/12] xfs: Remove macro XFS_BUF_SET_START, Chandra Seetharaman Re: [PATCH 06/12] xfs: Remove macro XFS_BUF_SET_START, Christoph Hellwig [PATCH 07/12] xfs: Remove the macro XFS_BUF_PTR, Chandra Seetharaman Re: [PATCH 07/12] xfs: Remove the macro XFS_BUF_PTR, Christoph Hellwig <= [PATCH 08/12] xfs: Remove the macro XFS_BUF_SET_PTR, Chandra Seetharaman Re: [PATCH 08/12] xfs: Remove the macro XFS_BUF_SET_PTR, Christoph Hellwig [PATCH 00/12] Remove number of macros from xfs_buf.h, Chandra Seetharaman [PATCH 01/12] xfs: Remove the macro XFS_BUF_BFLAGS, Chandra Seetharaman Re: [PATCH 01/12] xfs: Remove the macro XFS_BUF_BFLAGS, Alex Elder [PATCH 02/12] xfs: Remove the macro XFS_BUF_ZEROFLAGS, Chandra Seetharaman [PATCH 03/12] xfs: Remove the macro XFS_BUF_ERROR and family, Chandra Seetharaman Re: [PATCH 03/12] xfs: Remove the macro XFS_BUF_ERROR and family, Alex Elder Re: [PATCH 03/12] xfs: Remove the macro XFS_BUF_ERROR and family, Chandra Seetharaman Re: [PATCH 03/12] xfs: Remove the macro XFS_BUF_ERROR and family, Alex Elder

Previous by Date:	Re: [PATCH 08/12] xfs: Remove the macro XFS_BUF_SET_PTR, Christoph Hellwig
Next by Date:	Re: [PATCH] xfsprogs: don't hard code the shell binary, Christoph Hellwig
Previous by Thread:	[PATCH 07/12] xfs: Remove the macro XFS_BUF_PTR, Chandra Seetharaman
Next by Thread:	[PATCH 08/12] xfs: Remove the macro XFS_BUF_SET_PTR, Chandra Seetharaman
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 07/12] xfs: Remove the macro XFS_BUF_PTR