| To: | Alex Elder <aelder@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/5] xfs: use a cursor for bulk AIL insertion |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 8 Jul 2011 11:04:21 +1000 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <1310073976.1980.84.camel@doink> |
| References: | <1309757260-5484-1-git-send-email-david@xxxxxxxxxxxxx> <1309757260-5484-3-git-send-email-david@xxxxxxxxxxxxx> <20110704212055.GA24500@xxxxxxxxxxxxx> <1310073976.1980.84.camel@doink> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Thu, Jul 07, 2011 at 04:26:16PM -0500, Alex Elder wrote: > On Mon, 2011-07-04 at 17:20 -0400, Christoph Hellwig wrote: > > FYI: the following patch implementing my suggested cleanups survived a > > few rounds of xfsqa: > > It also eliminates the concern I had about using the value > of "lip" after falling off the front of the list with a > list_for_each_entry_reverse(). A null pointer signifies > no entry has a lower lsn than the one provided, and > that covers both the "empty list" and the "lower than > all other lsn's in the list" cases. > > I think you should base your solution on Christoph's > approach, Dave. Already been updated to use hch's code ;) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | [PATCH 4/4] xfstests: add mapped write fsx operations to 091, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 4/5] xfs: convert AIL cursors to use struct list_head, Dave Chinner |
| Previous by Thread: | Re: [PATCH 2/5] xfs: use a cursor for bulk AIL insertion, Alex Elder |
| Next by Thread: | Re: [PATCH 2/5] xfs: use a cursor for bulk AIL insertion, Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |