Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 6 Jul 2011 04:35:30 -0400
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20110706021935.GK1026@dastard>
References:	<20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094605.621819832@xxxxxxxxxxxxxxxxxxxxxx> <20110706021935.GK1026@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Jul 06, 2011 at 12:19:35PM +1000, Dave Chinner wrote:
> Took me a moment to realise what this does - turns the byte swap
> into a compile-time operation rather than a runtime operation.
> Nice.
> 
> Perhaps we should do that same optimisation in other magic number
> checks around the place?

We should, and I should have been more consistant about it.  In fact
I probably should split it into a separate patch.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 23/27] xfs: remove the unused xfs_bufhash structure, (continued) Re: [PATCH 23/27] xfs: remove the unused xfs_bufhash structure, Dave Chinner Re: [PATCH 23/27] xfs: remove the unused xfs_bufhash structure, Alex Elder [PATCH 14/27] xfs: kill struct xfs_dir2_sf, Christoph Hellwig Re: [PATCH 14/27] xfs: kill struct xfs_dir2_sf, Dave Chinner Re: [PATCH 14/27] xfs: kill struct xfs_dir2_sf, Christoph Hellwig Re: [PATCH 14/27] xfs: kill struct xfs_dir2_sf, Alex Elder Re: [PATCH 14/27] xfs: kill struct xfs_dir2_sf, Christoph Hellwig Re: [PATCH 14/27] xfs: kill struct xfs_dir2_sf, Alex Elder [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Christoph Hellwig Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Dave Chinner Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Christoph Hellwig <= Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Alex Elder [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Christoph Hellwig Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Dave Chinner Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Alex Elder [PATCH 27/27] xfs: avoid a few disk cache flushes, Christoph Hellwig Re: [PATCH 27/27] xfs: avoid a few disk cache flushes, Dave Chinner Re: [PATCH 27/27] xfs: avoid a few disk cache flushes, Alex Elder [PATCH 24/27] xfs: clean up buffer locking helpers, Christoph Hellwig Re: [PATCH 24/27] xfs: clean up buffer locking helpers, Dave Chinner Re: [PATCH 24/27] xfs: clean up buffer locking helpers, Alex Elder

Previous by Date:	Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, Christoph Hellwig
Next by Date:	Re: [PATCH 17/27] xfs: kill struct xfs_dir2_block, Christoph Hellwig
Previous by Thread:	Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Dave Chinner
Next by Thread:	Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Alex Elder
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block