Re: [PATCH 15/27] xfs: kill struct xfs_dir2

xfs

Re: [PATCH 15/27] xfs: kill struct xfs_dir2_sf

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 15/27] xfs: kill struct xfs_dir2_sf
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 30 Jun 2011 03:09:18 -0400
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20110630070449.GJ561@dastard>
References:	<20110629140109.003209430@xxxxxxxxxxxxxxxxxxxxxx> <20110629140339.466443510@xxxxxxxxxxxxxxxxxxxxxx> <20110630070449.GJ561@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Thu, Jun 30, 2011 at 05:04:49PM +1000, Dave Chinner wrote:
> On Wed, Jun 29, 2011 at 10:01:24AM -0400, Christoph Hellwig wrote:
> > The list field of it is never cactually used, so all uses can simply be
> > replaced with the xfs_dir2_sf_hdr_t type that it has as first member.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> I can't help but think this would have been a much smaller patch if
> you rolled the contents of the xfs_dir2_sf_hdr_t into xfs_dir2_sf_t
> and killed the xfs_dir2_sf_hdr_t instead. There's many more
> occurrences of xfs_dir2_sf_t than there are xfs_dir2_sf_hdr_t.

It would have been simpler, but using the xfs_dir2_sf_hdr_t makes
more sense to me.  If there's broad disagreement with this (and
the similar changes for the other structures) I'll revisit the naming
scheme.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 06/27] xfs: split xfs_setattr, (continued) Re: [PATCH 06/27] xfs: split xfs_setattr, Christoph Hellwig Re: [PATCH 06/27] xfs: split xfs_setattr, Alex Elder Re: [PATCH 06/27] xfs: split xfs_setattr, Dave Chinner [PATCH 21/27] xfs: cleanup the defintion of struct xfs_dir2_data_entry, Christoph Hellwig [PATCH 18/27] xfs: kill struct xfs_dir2_block, Christoph Hellwig [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Christoph Hellwig [PATCH 20/27] xfs: kill struct xfs_dir2_data, Christoph Hellwig [PATCH 23/27] xfs: remove the unused xfs_bufhash structure, Christoph Hellwig [PATCH 15/27] xfs: kill struct xfs_dir2_sf, Christoph Hellwig Re: [PATCH 15/27] xfs: kill struct xfs_dir2_sf, Dave Chinner Re: [PATCH 15/27] xfs: kill struct xfs_dir2_sf, Christoph Hellwig <= [PATCH 27/27] xfs: avoid a few disk cache flushes, Christoph Hellwig [PATCH 22/27] xfs: cleanup struct xfs_dir2_leaf, Christoph Hellwig [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig [PATCH 24/27] xfs: clean up buffer locking helpers, Christoph Hellwig [PATCH 17/27] xfs: avoid usage of struct xfs_dir2_block, Christoph Hellwig [PATCH 19/27] xfs: avoid usage of struct xfs_dir2_data, Christoph Hellwig Re: [PATCH 00/27] patch queue for Linux 3.1, Dave Chinner Re: [PATCH 00/27] patch queue for Linux 3.1, Christoph Hellwig

Previous by Date:	Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig
Next by Date:	Re: [PATCH 09/27] xfs: split xfs_itruncate_finish, Christoph Hellwig
Previous by Thread:	Re: [PATCH 15/27] xfs: kill struct xfs_dir2_sf, Dave Chinner
Next by Thread:	[PATCH 27/27] xfs: avoid a few disk cache flushes, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]