Re: [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Thu, 30 Jun 2011 11:34:10 +1000
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20110629140336.532726362@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110629140109.003209430@xxxxxxxxxxxxxxxxxxxxxx> <20110629140336.532726362@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Wed, Jun 29, 2011 at 10:01:10AM -0400, Christoph Hellwig wrote:
> Now that we reject direct reclaim in addition to always using GFP_NOFS
> allocation there's no chance we'll ever end up in ->writepage with
> PF_FSTRANS set.  Add a WARN_ON if we hit this case, and stop checking
> if we'd actually need to start a transaction.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Alex Elder <aelder@xxxxxxx>

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, (continued) [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Alex Elder Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Dave Chinner Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Christoph Hellwig Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Alex Elder Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Dave Chinner [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Christoph Hellwig Re: [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Alex Elder [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Christoph Hellwig Re: [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Dave Chinner <= [PATCH 08/27] xfs: kill xfs_itruncate_start, Christoph Hellwig Re: [PATCH 08/27] xfs: kill xfs_itruncate_start, Alex Elder [PATCH 10/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Christoph Hellwig Re: [PATCH 10/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Dave Chinner [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Christoph Hellwig Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Christoph Hellwig Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner

Previous by Date:	Re: [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, Dave Chinner
Next by Date:	Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner
Previous by Thread:	[PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Christoph Hellwig
Next by Thread:	[PATCH 08/27] xfs: kill xfs_itruncate_start, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]