| To: | Bill Kendall <wkendall@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfsprogs: fix open_by_handle memory leak |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 9 May 2011 10:06:57 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1304700177-8505-1-git-send-email-wkendall@xxxxxxx> |
| References: | <1304700177-8505-1-git-send-email-wkendall@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, May 06, 2011 at 11:42:57AM -0500, Bill Kendall wrote: > open_by_handle() calls handle_to_fshandle() which > allocates an fshandle on the heap, which is never > freed by open_by_handle(). There is no need to > call handle_to_fshandle() though, just pass the > fhandle (rather than fshandle) to handle_to_fsfd(), > like the other *_by_handle() functions do. > > Signed-off-by: Bill Kendall <wkendall@xxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2.6.38.4: xfs speed problem?, Michael Monnerie |
|---|---|
| Next by Date: | Re: [PATCH 1/5] xfs: ensure reclaim cursor is reset correctly at end of AG, Christoph Hellwig |
| Previous by Thread: | [PATCH] xfsprogs: fix open_by_handle memory leak, Bill Kendall |
| Next by Thread: | 2.6.38.4: xfs speed problem?, Justin Piszcz |
| Indexes: | [Date] [Thread] [Top] [All Lists] |