| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: fix bmbt block allocation failures |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 11 Apr 2011 19:41:58 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1302489251-1512-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1302489251-1512-1-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Apr 11, 2011 at 12:34:11PM +1000, Dave Chinner wrote: > http://oss.sgi.com/archives/xfs/2010-09/msg00438.html). Firstly, > the missing args->total was causing the initial block to be > allocated from the freespace reserve. Secondly that the NEAR_BNO > allocation should probably be a START_BNO allocation to allow blocks > to be taken from a higher numbered AG. Looking over the use of ->total, isn't the ialloc btree code also incorrect by setting ->total to 0? The actual change looks good to me, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2 question about XFS fragmentation and _fsr, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] xfs: fix bmbt block allocation failures, Dave Chinner |
| Previous by Thread: | [PATCH] xfs: fix bmbt block allocation failures, Dave Chinner |
| Next by Thread: | Re: [PATCH] xfs: fix bmbt block allocation failures, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |