Re: [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

> +/*
> + * Return a pointer to the first item in the AIL.
> + * If the AIL is empty, then return NULL.
> + */

> +/*
> + * Return a pointer to the item which follows
> + * the given item in the AIL.  If the given item
> + * is the last item in the list, then return NULL.
> + */

These comment seem to line break strangely early.

> +     ASSERT((&next_lip->li_ail == &ailp->xa_ail) ||
> +            (XFS_LSN_CMP(next_lip->li_lsn, lsn) <= 0));

no need for the inner braces here.

> +     list_splice_init(list, &next_lip->li_ail);
> +     return;

and no need for the return.


I know it's all nitpicking about pre-existing code, but when you touch
it anyway it might make sense to tidy it up.