xfs
[Top] [All Lists]

Re: [PATCH 8/9] xfs: catch bad block numbers freeing extents.

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 8/9] xfs: catch bad block numbers freeing extents.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 6 Apr 2011 09:59:51 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1302070758-17312-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1302070758-17312-1-git-send-email-david@xxxxxxxxxxxxx> <1302070758-17312-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +     /* validate the extent size is legal now we have the agf locked */
> +     if (!args.agbp) {
> +             error = EFSCORRUPTED;
> +             goto error0;
> +     }

This is not a corruption case, but would require someone changing
xfs_fix_freelist and messing up.  I think the check can be removed
given that the potentially added bug would trivially trip up as
a NULL pointer dereference.

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>