Re: [PATCH 1/9] xfs: fix extent format buffer allocation size

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 1/9] xfs: fix extent format buffer allocation size
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 6 Apr 2011 09:38:17 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1302070758-17312-2-git-send-email-david@xxxxxxxxxxxxx>
References:	<1302070758-17312-1-git-send-email-david@xxxxxxxxxxxxx> <1302070758-17312-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Apr 06, 2011 at 04:19:10PM +1000, Dave Chinner wrote:
> +     ext_buffer = kmem_alloc(XFS_IFORK_SIZE(ip, whichfork),
> +                                                     KM_SLEEP | KM_NOFS);

As mentioned before the KM_NOFS is a change from the previous version
and really should not be needed.

Also the feedback that the new helper needs to be under the
!XFS_NATIVE_ENDIAN ifdef wasn't picked up either.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/9] xfs: candidate fixes for 2.6.39, Dave Chinner [PATCH 2/9] xfs: introduce a xfssyncd workqueue, Dave Chinner [PATCH 1/9] xfs: fix extent format buffer allocation size, Dave Chinner Re: [PATCH 1/9] xfs: fix extent format buffer allocation size, Christoph Hellwig <= Re: [PATCH 1/9] xfs: fix extent format buffer allocation size, Dave Chinner Re: [PATCH 1/9] xfs: fix extent format buffer allocation size, Christoph Hellwig [PATCH 7/9] xfs: push the AIL from memory reclaim and periodic sync, Dave Chinner Re: [PATCH 7/9] xfs: push the AIL from memory reclaim and periodic sync, Christoph Hellwig Re: [PATCH 7/9] xfs: push the AIL from memory reclaim and periodic sync, Dave Chinner [PATCH 9/9] xfs: convert log tail checking to a warning, Dave Chinner Re: [PATCH 9/9] xfs: convert log tail checking to a warning, Christoph Hellwig Re: [PATCH 9/9] xfs: convert log tail checking to a warning, Dave Chinner [PATCH 3/9] xfs: convert ENOSPC inode flushing to use new syncd workqueue, Dave Chinner [PATCH 8/9] xfs: catch bad block numbers freeing extents., Dave Chinner

Previous by Date:	Re: SL's kickstart corrupting XFS by "repairing" GPT labels?, Dave Chinner
Next by Date:	Re: [PATCH 8/9] xfs: catch bad block numbers freeing extents., Christoph Hellwig
Previous by Thread:	[PATCH 1/9] xfs: fix extent format buffer allocation size, Dave Chinner
Next by Thread:	Re: [PATCH 1/9] xfs: fix extent format buffer allocation size, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]