Re: [PATCH 1/6] xfs: optimize AGFL refills

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Mar 23, 2011 at 10:30:54AM +1100, Dave Chinner wrote:
> > +   if (error)
> > +           xfs_alloc_busy_insert(tp, args.agno, args.agbno, len);
> 
> Shouldn't that be "if (!error)"?  i.e. if we freed the extent
> successfully we need to insert it in the busy list. This current
> code has the effect of never inserting freed data extents in the
> busy list....

Yes, it should.  This got messed up at some point during reshuffling
the series.