Re: [PATCH 2/2] xfs: more sensible inode refcounting for ialloc

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Sun, Feb 13, 2011 at 08:26:42AM -0500, Christoph Hellwig wrote:
> Currently we return iodes from xfs_ialloc with just a single reference held.
> But we need two references, as one is dropped during transaction commit and
> the second needs to be transfered to the VFS.  Change xfs_ialloc to use
> xfs_iget plus xfs_trans_ijoin_ref to grab two references to the inode,
> and remove the now superflous IHOLD calls from all callers.  This also
> greatly simplifies the error handling in xfs_create and also allow to remove
> xfs_trans_iget as no other callers are left.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Nice. Good to get rid of the lock flags count hack xfs_trans_iget()
used.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx