| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 7/8] xfs: handle CIl transaction commit failures correctly |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 25 Jan 2011 04:53:21 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1295945444-29488-8-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1295945444-29488-1-git-send-email-david@xxxxxxxxxxxxx> <1295945444-29488-8-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Jan 25, 2011 at 07:50:43PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Failure to commit a transaction into the CIL is not handled > correctly. This currently can only happen when racing with a > shutdown and requires an explicit shutdown check, so it rare and can > be avoided. Remove the shutdown check and make the CIL commit a void > function to indicate it will always succeed, thereby removing the > incorrectly handled failure case. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH 8/8] xfs: fix dquot shaker deadlock, Christoph Hellwig |
|---|---|
| Next by Date: | Re: Optimize RAID0 for max IOPS?, Wolfgang Denk |
| Previous by Thread: | [PATCH 7/8] xfs: handle CIl transaction commit failures correctly, Dave Chinner |
| Next by Thread: | Re: [PATCH 7/8] xfs: handle CIl transaction commit failures correctly, Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |