Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 18 Jan 2011 08:03:14 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1294792553-8378-1-git-send-email-david@xxxxxxxxxxxxx>
References:	<1294792553-8378-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

The series looks good to me.  One thing that feels a bit odd is
the xfs_printk.[ch] name - the functions exported to the rest of the
code don't contain prink anyway.  Maybe xfs_msg.[ch] or
xfs_message.[ch]?

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

for the whole series.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 05/12] xfs: convert xfs_cmn_err to xfs_alert_tag, (continued) [PATCH 05/12] xfs: convert xfs_cmn_err to xfs_alert_tag, Dave Chinner [PATCH 06/12] xfs: kill xfs_fs_repair_cmn_err() macro, Dave Chinner [PATCH 01/12] xfs: prevent NMI timeouts in cmn_err, Dave Chinner Re: [PATCH 01/12] xfs: prevent NMI timeouts in cmn_err, Alex Elder Re: [PATCH 01/12] xfs: prevent NMI timeouts in cmn_err, Christoph Hellwig Re: [PATCH 01/12] xfs: prevent NMI timeouts in cmn_err, Dave Chinner XFS master branch update, Alex Elder [PATCH 03/12] xfs: Convert linux-2.6/ files to new logging interface, Dave Chinner Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure, Alex Elder Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure, Dave Chinner Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure, Christoph Hellwig <= Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure, Dave Chinner

Previous by Date:	Re: [PATCH 12/12] xfs: kill support/debug.[ch], Christoph Hellwig
Next by Date:	Re: [PATCH] xfsprogs: add fpunch command for hole punching via fallocate, Josef Bacik
Previous by Thread:	Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure, Dave Chinner
Next by Thread:	Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]