| To: | Alex Elder <aelder@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 02/12] xfsprogs: simplify leading '/' handling in generate_obfuscated_name() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 10 Jan 2011 15:13:35 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1293741612.2294.354.camel@doink> |
| References: | <1293741612.2294.354.camel@doink> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 30, 2010 at 02:40:12PM -0600, Alex Elder wrote: > In generate_obfuscated_name(), the incoming file name is allowed to > start with a '/' character, in which case it is copied over to the > new file name and ignored for the remainder of the hash calculation. > Simplify the affected code by processing the '/' right away, and > using a pointer thereafter for the start of the new file name. The actual change looks good to me, but why would we ever have a / in the filename, and if we do why would we treat it special? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 01/12] xfsprogs: some things aren't all that special, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 01/12] xfsprogs: some things aren't all that special, Alex Elder |
| Previous by Thread: | Re: [PATCH 01/12] xfsprogs: some things aren't all that special, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 02/12] xfsprogs: simplify leading '/' handling in generate_obfuscated_name(), Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |