| To: | Honza Fikar <j.fikar@xxxxxxxxx> |
|---|---|
| Subject: | Re: no rw xfs file systems in mtab: /proc/mounts |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 29 Dec 2010 08:09:03 -0500 |
| Cc: | Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <4D138457.8020008@xxxxxxxxx> |
| References: | <AANLkTi=Xes02L3XfZvUu6Yh2yi2FR8GtpVdOGzngVjJk@xxxxxxxxxxxxxx> <4D13648B.8000105@xxxxxxxxxxx> <4D138457.8020008@xxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
Can you please apply the debug patch below and see what output fsr gives
with it?
Index: xfsprogs-dev/fsr/xfs_fsr.c
===================================================================
--- xfsprogs-dev.orig/fsr/xfs_fsr.c 2010-12-29 14:02:59.618003862 +0100
+++ xfsprogs-dev/fsr/xfs_fsr.c 2010-12-29 14:04:32.795004496 +0100
@@ -405,10 +405,16 @@ initallfs(char *mtab)
while ((mp = getmntent(fp))) {
int rw = 0;
- if (strcmp(mp->mnt_type, MNTTYPE_XFS ) != 0 ||
- stat64(mp->mnt_fsname, &sb) == -1 ||
- !S_ISBLK(sb.st_mode))
+ if (strcmp(mp->mnt_type, MNTTYPE_XFS ) != 0)
continue;
+ if (stat64(mp->mnt_fsname, &sb) == -1) {
+ printf("fsr: cannot stat %s\n", mp->mnt_fsname);
+ continue;
+ }
+ if (!S_ISBLK(sb.st_mode)) {
+ printf("fsr: %s is not a block device\n",
mp->mnt_fsname);
+ continue;
+ }
cp = strtok(mp->mnt_opts,",");
do {
@@ -416,8 +422,7 @@ initallfs(char *mtab)
rw++;
} while ((cp = strtok(NULL, ",")) != NULL);
if (rw == 0) {
- if (dflag)
- fsrprintf(_("Skipping %s: not mounted rw\n"),
+ printf(_("Skipping %s: not mounted rw\n"),
mp->mnt_fsname);
continue;
}
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 06/34] xfs: dynamic speculative EOF preallocation, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 30/34] xfs: convert l_tail_lsn to an atomic variable., Alex Elder |
| Previous by Thread: | Re: no rw xfs file systems in mtab: /proc/mounts, Honza Fikar |
| Next by Thread: | xfssyncd and disk spin down, Petre Rodan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |