Re: [PATCH 02/34] xfs: use KM_NOFS for allocations during attribute list

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 02/34] xfs: use KM_NOFS for allocations during attribute list operations
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 21 Dec 2010 10:16:14 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1292916570-25015-3-git-send-email-david@xxxxxxxxxxxxx>
References:	<1292916570-25015-1-git-send-email-david@xxxxxxxxxxxxx> <1292916570-25015-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Dec 21, 2010 at 06:28:58PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When listing attributes, we are doiing memory allocations under the
> inode ilock using only KM_SLEEP. This allows memory allocation to
> recurse back into the filesystem and do writeback, which may the
> ilock we already hold on the current inode. THis will deadlock.
> Hence use KM_NOFS for such allocations outside of transaction
> context to ensure that reclaim recursion does not occur.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/34] xfs: scalability patchset for 2.6.38, Dave Chinner [PATCH 04/34] xfs: use generic per-cpu counter infrastructure, Dave Chinner [PATCH 07/34] xfs: don't truncate prealloc from frequently accessed inodes, Dave Chinner Re: [PATCH 07/34] xfs: don't truncate prealloc from frequently accessed inodes, Christoph Hellwig [PATCH 02/34] xfs: use KM_NOFS for allocations during attribute list operations, Dave Chinner Re: [PATCH 02/34] xfs: use KM_NOFS for allocations during attribute list operations, Christoph Hellwig <= [PATCH 03/34] lib: percpu counter add unless less than functionality, Dave Chinner Re: [PATCH 03/34] lib: percpu counter add unless less than functionality, Alex Elder Re: [PATCH 03/34] lib: percpu counter add unless less than functionality, Dave Chinner [PATCH 01/34] xfs: provide a inode iolock lockdep class, Dave Chinner Re: [PATCH 01/34] xfs: provide a inode iolock lockdep class, Christoph Hellwig [PATCH 05/34] xfs: demultiplex xfs_icsb_modify_counters(), Dave Chinner [PATCH 06/34] xfs: dynamic speculative EOF preallocation, Dave Chinner Re: [PATCH 06/34] xfs: dynamic speculative EOF preallocation, Christoph Hellwig Re: [PATCH 06/34] xfs: dynamic speculative EOF preallocation, Dave Chinner Re: [PATCH 06/34] xfs: dynamic speculative EOF preallocation, Dave Chinner

Previous by Date:	Re: [PATCH 01/34] xfs: provide a inode iolock lockdep class, Christoph Hellwig
Next by Date:	Re: [PATCH 07/34] xfs: don't truncate prealloc from frequently accessed inodes, Christoph Hellwig
Previous by Thread:	[PATCH 02/34] xfs: use KM_NOFS for allocations during attribute list operations, Dave Chinner
Next by Thread:	[PATCH 03/34] lib: percpu counter add unless less than functionality, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]