Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Tue, 21 Dec 2010 11:55:41 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20101220113458.GA12806@xxxxxxxxxxxxx>
References:	<1292215483-18224-1-git-send-email-david@xxxxxxxxxxxxx> <1292215483-18224-2-git-send-email-david@xxxxxxxxxxxxx> <20101220113458.GA12806@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Mon, Dec 20, 2010 at 06:34:58AM -0500, Christoph Hellwig wrote:
> On Mon, Dec 13, 2010 at 03:44:32PM +1100, Dave Chinner wrote:
> > -           __field(void *, reserve_headq)
> > -           __field(void *, write_headq)
> > +           __field(void *, reserveq)
> > +           __field(void *, writeq)
> 
> To repeat my question from the last review:  what's the point in logging
> this at all?  There's not much we can do with it from trace-cmd / perf
> output.  What might be more useful is a list_empty() boolean flag.

Oh, I missed that when running through all the comments. Thanks for
pointing it out again - I'll fix it this time.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 02/12] xfs: fact out common grant head/log tail verification code, (continued) [PATCH 02/12] xfs: fact out common grant head/log tail verification code, Dave Chinner Re: [PATCH 02/12] xfs: fact out common grant head/log tail verification code, Christoph Hellwig [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer, Dave Chinner Re: [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer, Christoph Hellwig [PATCH 12/12] xfs: kill useless spinlock_destroy macro, Dave Chinner [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Dave Chinner Re: [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Christoph Hellwig Re: [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Dave Chinner [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Christoph Hellwig Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner <= [PATCH 06/12] xfs: make AIL tail pushing independent of the grant lock, Dave Chinner Re: [PATCH 06/12] xfs: make AIL tail pushing independent of the grant lock, Christoph Hellwig [PATCH 07/12] xfs: convert l_last_sync_lsn to an atomic variable, Dave Chinner [PATCH 05/12] xfs: use wait queues directly for the log wait queues, Dave Chinner Re: [PATCH 05/12] xfs: use wait queues directly for the log wait queues, Christoph Hellwig

Previous by Date:	Re: xfs_efi_item slab leak, Dave Chinner
Next by Date:	[PATCH] xfs: use KM_NOFS for allocations during attribute list operations, Dave Chinner
Previous by Thread:	Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Christoph Hellwig
Next by Thread:	[PATCH 06/12] xfs: make AIL tail pushing independent of the grant lock, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]