Re: [PATCH 4/7] xfs: split direct IO write path from xfs_file_aio_write

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Mon, Dec 20, 2010 at 06:29:47AM -0500, Christoph Hellwig wrote:
> On Fri, Dec 17, 2010 at 06:31:25PM +1100, Dave Chinner wrote:
> > > Speaking of that, shouldn't xfs_file_aio_read also take the iolock
> > > exclusive during the page invalidation and then demote it, just like
> > > the write case?  The above helpers would enforce that nicely.
> > 
> > Probably, though it might be best to leave that to another cleanup
> > series. I'll see how much perturbation of the read path it makes....
> 
> Yes, it should be a separate patch for sure.  If you prefer another
> series that's fine with me, too.

Turns out to be pretty trivial to do - I included it in the
new xfs_rw_ilock conversion patch for the moment.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx