Re: [PATCH 05/12] xfs: use wait queues directly for the log wait queues

xfs

Re: [PATCH 05/12] xfs: use wait queues directly for the log wait queues

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 05/12] xfs: use wait queues directly for the log wait queues
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 20 Dec 2010 06:40:59 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1292215483-18224-6-git-send-email-david@xxxxxxxxxxxxx>
References:	<1292215483-18224-1-git-send-email-david@xxxxxxxxxxxxx> <1292215483-18224-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Dec 13, 2010 at 03:44:36PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The log grant queues are one of the few places left using sv_t
> constructs for waiting. Given we are touching this code, we should
> convert them to plain wait queues. While there, convert all the
> other sv_t users in the log code as well.
> 
> Seeing as this removes the last users of the sv_t type, remove the
> header file defining the wrapper and the fragments that still
> reference it.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., (continued) [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Dave Chinner Re: [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Christoph Hellwig Re: [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Dave Chinner [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Christoph Hellwig Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner [PATCH 06/12] xfs: make AIL tail pushing independent of the grant lock, Dave Chinner Re: [PATCH 06/12] xfs: make AIL tail pushing independent of the grant lock, Christoph Hellwig [PATCH 07/12] xfs: convert l_last_sync_lsn to an atomic variable, Dave Chinner [PATCH 05/12] xfs: use wait queues directly for the log wait queues, Dave Chinner Re: [PATCH 05/12] xfs: use wait queues directly for the log wait queues, Christoph Hellwig <=

Previous by Date:	Re: [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer, Christoph Hellwig
Next by Date:	Re: [PATCH 06/12] xfs: make AIL tail pushing independent of the grant lock, Christoph Hellwig
Previous by Thread:	[PATCH 05/12] xfs: use wait queues directly for the log wait queues, Dave Chinner
Next by Thread:	[PATCH] xfstests: pwrite hang when writing from mmaped buffer of the same page, Zhong, Xin
Indexes:	[Date] [Thread] [Top] [All Lists]