Re: [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 20 Dec 2010 06:40:20 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1292215483-18224-5-git-send-email-david@xxxxxxxxxxxxx>
References:	<1292215483-18224-1-git-send-email-david@xxxxxxxxxxxxx> <1292215483-18224-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Dec 13, 2010 at 03:44:35PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Prepare for switching the grant heads to atomic variables by
> combining the two 32 bit values that make up the grant head into a
> single 64 bit variable.  Provide wrapper functions to combine and
> split the grant heads appropriately for calculations and use them as
> necessary.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Minor nitpick:

> +     if ((tail_cycle == head_cycle) && (head_bytes >= tail_bytes)) {
> +             free_bytes = log->l_logsize - (head_bytes - tail_bytes);
> +     } else if ((tail_cycle + 1) < head_cycle) {

Lots of superflous braces in the if statements.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 03/12] xfs: rework log grant space calculations, (continued) [PATCH 03/12] xfs: rework log grant space calculations, Dave Chinner Re: [PATCH 03/12] xfs: rework log grant space calculations, Christoph Hellwig [PATCH 09/12] xfs: convert log grant heads to atomic variables, Dave Chinner [PATCH 11/12] xfs: convert grant head manipulations to lockless algorithm, Dave Chinner Re: [PATCH 11/12] xfs: convert grant head manipulations to lockless algorithm, Christoph Hellwig [PATCH 10/12] xfs: introduce new locks for the log grant ticket wait queues, Dave Chinner Re: [PATCH 10/12] xfs: introduce new locks for the log grant ticket wait queues, Christoph Hellwig [PATCH 02/12] xfs: fact out common grant head/log tail verification code, Dave Chinner Re: [PATCH 02/12] xfs: fact out common grant head/log tail verification code, Christoph Hellwig [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer, Dave Chinner Re: [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer, Christoph Hellwig <= [PATCH 12/12] xfs: kill useless spinlock_destroy macro, Dave Chinner [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Dave Chinner Re: [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Christoph Hellwig Re: [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Dave Chinner [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Christoph Hellwig Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner [PATCH 06/12] xfs: make AIL tail pushing independent of the grant lock, Dave Chinner Re: [PATCH 06/12] xfs: make AIL tail pushing independent of the grant lock, Christoph Hellwig [PATCH 07/12] xfs: convert l_last_sync_lsn to an atomic variable, Dave Chinner

Previous by Date:	Re: [PATCH 03/12] xfs: rework log grant space calculations, Christoph Hellwig
Next by Date:	Re: [PATCH 05/12] xfs: use wait queues directly for the log wait queues, Christoph Hellwig
Previous by Thread:	[PATCH 04/12] xfs: combine grant heads into a single 64 bit integer, Dave Chinner
Next by Thread:	[PATCH 12/12] xfs: kill useless spinlock_destroy macro, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]