Re: [PATCH 9/9] xfs: use AIL bulk delete function to implement single de

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 9/9] xfs: use AIL bulk delete function to implement single delete
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 17 Dec 2010 09:16:33 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1292214743-18073-10-git-send-email-david@xxxxxxxxxxxxx>
References:	<1292214743-18073-1-git-send-email-david@xxxxxxxxxxxxx> <1292214743-18073-10-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Dec 13, 2010 at 03:32:23PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> We now have two copies of AIL delete operations that are mostly
> duplicate functionality. The single log item deletes can be
> implemented via the bulk updates by turning xfs_trans_ail_delete()
> into a simple wrapper. This removes all the duplicate delete
> functionality and associated helpers.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

The same comment about just taking the address as for the previous patch
applies.

<Prev in Thread]	Current Thread	[Next in Thread>
xfs: AIL lock contention reduction V3, Dave Chinner [PATCH 5/9] xfs: reduce the number of AIL push wakeups, Dave Chinner Re: [PATCH 5/9] xfs: reduce the number of AIL push wakeups, Christoph Hellwig Re: [PATCH 5/9] xfs: reduce the number of AIL push wakeups, Dave Chinner Re: [PATCH 5/9] xfs: reduce the number of AIL push wakeups, Christoph Hellwig [PATCH 9/9] xfs: use AIL bulk delete function to implement single delete, Dave Chinner Re: [PATCH 9/9] xfs: use AIL bulk delete function to implement single delete, Christoph Hellwig <= [PATCH 3/9] xfs: clean up xfs_ail_delete(), Dave Chinner [PATCH 1/9] xfs: fix EFI transaction cancellation., Dave Chinner Re: [PATCH 1/9] xfs: fix EFI transaction cancellation., Christoph Hellwig [PATCH 4/9] xfs: bulk AIL insertion during transaction commit, Dave Chinner Re: [PATCH 4/9] xfs: bulk AIL insertion during transaction commit, Christoph Hellwig [PATCH 7/9] xfs: remove all the inodes on a buffer from the AIL in bulk, Dave Chinner Re: [PATCH 7/9] xfs: remove all the inodes on a buffer from the AIL in bulk, Christoph Hellwig [PATCH 2/9] xfs: Pull EFI/EFD handling out from under the AIL lock, Dave Chinner Re: [PATCH 2/9] xfs: Pull EFI/EFD handling out from under the AIL lock, Christoph Hellwig Re: [PATCH 2/9] xfs: Pull EFI/EFD handling out from under the AIL lock, Dave Chinner

Previous by Date:	Re: [PATCH 8/9] xfs: use AIL bulk update function to implement single updates, Christoph Hellwig
Next by Date:	[XFS updates] XFS development tree branch, master, updated. v2.6.37-rc4-23-g489a150, xfs
Previous by Thread:	[PATCH 9/9] xfs: use AIL bulk delete function to implement single delete, Dave Chinner
Next by Thread:	[PATCH 3/9] xfs: clean up xfs_ail_delete(), Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]