Re: [PATCH 02/14] xfs: clean up log space grant functions

xfs

Re: [PATCH 02/14] xfs: clean up log space grant functions

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 02/14] xfs: clean up log space grant functions
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 2 Dec 2010 06:40:50 -0500
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20101202014833.GN16922@dastard>
References:	<1290994712-21376-1-git-send-email-david@xxxxxxxxxxxxx> <1290994712-21376-3-git-send-email-david@xxxxxxxxxxxxx> <20101201123032.GA20378@xxxxxxxxxxxxx> <20101202014833.GN16922@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Thu, Dec 02, 2010 at 12:48:33PM +1100, Dave Chinner wrote:
> Ok, so your main objection is the needless addition to the queue?
> That can be avoided easily enough via a local variable. Would that
> be sufficient to alleviate your concerns?

The main objection is that the new code might be a bit shorted,
but is a lot less readable.  If you really want it go with it and
an updated changelog mentioning the behaviour change, but I don't
really feel too good about it.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 02/14] xfs: clean up log space grant functions, Christoph Hellwig Re: [PATCH 02/14] xfs: clean up log space grant functions, Dave Chinner Re: [PATCH 02/14] xfs: clean up log space grant functions, Christoph Hellwig <= Re: [PATCH 02/14] xfs: clean up log space grant functions, Dave Chinner

Previous by Date:	Re: [PATCH 1/8] xfs: Pull EFI/EFD handling out from under the AIL lock, Christoph Hellwig
Next by Date:	Re: [PATCH 03/14] xfs: convert log grant heads to LSN notation, Christoph Hellwig
Previous by Thread:	Re: [PATCH 02/14] xfs: clean up log space grant functions, Dave Chinner
Next by Thread:	Re: [PATCH 02/14] xfs: clean up log space grant functions, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]