| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 05/14] xfs: make AIL tail pushing independent of the grant lock |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 2 Dec 2010 13:04:09 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20101201124540.GC612@xxxxxxxxxxxxx> |
| References: | <1290994712-21376-1-git-send-email-david@xxxxxxxxxxxxx> <1290994712-21376-6-git-send-email-david@xxxxxxxxxxxxx> <20101201124540.GC612@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Wed, Dec 01, 2010 at 07:45:40AM -0500, Christoph Hellwig wrote: > Once l_tail_lsn and l_last_sync_lsn are converted to atomic64_ts later > in the series passing them in separately becomes pointless again. Maybe > scale the patch back a bit and require the caller to hold l_grant_lock > for now, until the atomic64_t conversion happens. Same reasoning as for the change to xlog_space_left - the values should only be sampled once for correctness, which is why I pass them into the function. more "const" annotations, I guess. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 04/14] xfs: use wait queues directly for log grant queues, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 08/14] xfs: convert log grant heads to atomic variables, Dave Chinner |
| Previous by Thread: | Re: [PATCH 05/14] xfs: make AIL tail pushing independent of the grant lock, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 06/14] xfs: convert l_last_sync_lsn to an atomic variable, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |