| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 03/14] xfs: convert log grant heads to LSN notation |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 1 Dec 2010 07:42:35 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1290994712-21376-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1290994712-21376-1-git-send-email-david@xxxxxxxxxxxxx> <1290994712-21376-4-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
The patch looks good to me, but I really hate overloading the lsn types and helpers. Just add duplicated of CYCLE_LSN/BLOCK_LSN and xlog_assign_lsn for a new type as use them. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 04/14] xfs: use wait queues directly for log grant queues, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 05/14] xfs: make AIL tail pushing independent of the grant lock, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 04/14] xfs: use wait queues directly for log grant queues, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 03/14] xfs: convert log grant heads to LSN notation, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |