| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 07/10] xfs: remove xfs_probe_cluster |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 1 Dec 2010 15:43:24 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20101122130904.341654979@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20101122130506.868076797@xxxxxxxxxxxxxxxxxxxxxx> <20101122130904.341654979@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Mon, Nov 22, 2010 at 08:05:13AM -0500, Christoph Hellwig wrote: > xfs_map_blocks always calls xfs_bmapi with the XFS_BMAPI_ENTIRE entire > flag, which tells it to not cap the extent at the passed in size, but > just treat the size as an minimum to map. This means xfs_probe_cluster > is entirely useless as we'll always get the whole extent back anyway. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 06/10] xfs: simplify xfs_map_blocks, Dave Chinner |
|---|---|
| Next by Date: | issue with unmount of XFS partation, naveen yadav |
| Previous by Thread: | [PATCH 07/10] xfs: remove xfs_probe_cluster, Christoph Hellwig |
| Next by Thread: | [PATCH 04/10] xfs: cleanup the xfs_iomap_write_* helpers, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |