Re: [PATCH 2/8] xfs: clean up xfs_ail

xfs

Re: [PATCH 2/8] xfs: clean up xfs_ail_delete()

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 2/8] xfs: clean up xfs_ail_delete()
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 30 Nov 2010 15:19:13 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1290993152-20999-3-git-send-email-david@xxxxxxxxxxxxx>
References:	<1290993152-20999-1-git-send-email-david@xxxxxxxxxxxxx> <1290993152-20999-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Nov 29, 2010 at 12:12:26PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_ail_delete() has a needlessly complex interface. It returns the log item
> that was passed in for deletion (which the callers then assert is identical to
> the one passed in), and callers of xfs_ail_delete() still need to invalidate
> current traversal cursors.
> 
> Make xfs_ail_delete() return void, move the cursor invalidation inside it, and
> clean up the callers just to use the log item pointer they passed in.
> 
> While cleaning up, remove the messy and unnecessary "/* ARGUSED */" comments
> around all these functions.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/8] xfs: AIL lock contention reduction V2, Dave Chinner [PATCH 2/8] xfs: clean up xfs_ail_delete(), Dave Chinner Re: [PATCH 2/8] xfs: clean up xfs_ail_delete(), Christoph Hellwig <= [PATCH 7/8] xfs: use AIL bulk update function to implement single updates, Dave Chinner [PATCH 8/8] xfs: use AIL bulk delete function to implement single delete, Dave Chinner [PATCH 3/8] xfs: bulk AIL insertion during transaction commit, Dave Chinner Re: [PATCH 3/8] xfs: bulk AIL insertion during transaction commit, Christoph Hellwig [PATCH 1/8] xfs: Pull EFI/EFD handling out from under the AIL lock, Dave Chinner Re: [PATCH 1/8] xfs: Pull EFI/EFD handling out from under the AIL lock, Christoph Hellwig [PATCH 6/8] xfs: remove all the inodes on a buffer from the AIL in bulk, Dave Chinner [PATCH 5/8] xfs: consume iodone callback items on buffers as they are processed, Dave Chinner Re: [PATCH 5/8] xfs: consume iodone callback items on buffers as they are processed, Christoph Hellwig [PATCH 4/8] xfs: reduce the number of AIL push wakeups, Dave Chinner

Previous by Date:	Re: [PATCH 1/8] xfs: Pull EFI/EFD handling out from under the AIL lock, Christoph Hellwig
Next by Date:	Re: [PATCH 4/8] xfs: reduce the number of AIL push wakeups, Christoph Hellwig
Previous by Thread:	[PATCH 2/8] xfs: clean up xfs_ail_delete(), Dave Chinner
Next by Thread:	[PATCH 7/8] xfs: use AIL bulk update function to implement single updates, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]