| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: fix exporting with left over 64-bit inodes |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 22 Nov 2010 05:23:51 -0500 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, Samuel Kvasnica <samuel.kvasnica@xxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20101122003754.GE13830@dastard> |
| References: | <20101119133848.GA5471@xxxxxxxxxxxxx> <20101122003754.GE13830@dastard> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Nov 22, 2010 at 11:37:54AM +1100, Dave Chinner wrote: > Won't this mean that people exporting non-root directories suddenly > have those exports stop working on a kernel upgrade due to changing > the handle format? No, if NFSD used ->encode_fh to encode the handle for the export directory we wouldn't even have that problem. NFSD directly encodes i_ino as 32-bit value for the legacy subdirectory export fs handle. So it will break whenever that particulat inode has a too large inode number. Check fs/nfsd/nfsfh.h:mk_fsid() for the glory details. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: fix exporting with left over 64-bit inodes, Samuel Kvasnica |
|---|---|
| Next by Date: | VDC! Khuyen Mai Cuc Soc, Con Loc Qua Tang!, VDC! Khuyen Mai Cuc Soc, Con Loc Qua Tang! \" Moi Ngay 1000 Qua Tang\" |
| Previous by Thread: | Re: [PATCH] xfs: fix exporting with left over 64-bit inodes, Samuel Kvasnica |
| Next by Thread: | [PATCH v4 4/9] xfsrestore: mmap dirent names for faster lookups, Bill Kendall |
| Indexes: | [Date] [Thread] [Top] [All Lists] |