Re: [PATCH v3 1/9] xfsrestore: turn off NODECHK

To:	wkendall@xxxxxxx
Subject:	Re: [PATCH v3 1/9] xfsrestore: turn off NODECHK
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 17 Nov 2010 04:20:07 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20101116150703.775155599@xxxxxxx>
References:	<20101116150502.179825893@xxxxxxx> <20101116150703.775155599@xxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Nov 16, 2010 at 09:05:03AM -0600, wkendall@xxxxxxx wrote:
> The NODECHK macro should only be enabled as needed for
> development/debugging. Having it on limits xfsrestore to dumps
> with 268 million directory entries instead of 4 billion. 
> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>
> 
> Reviewed-by: Alex Elder <aelder@xxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH v3 4/9] xfsrestore: mmap dirent names for faster lookups, (continued) Re: [PATCH v3 4/9] xfsrestore: mmap dirent names for faster lookups, Bill Kendall [PATCH v3 9/9] xfsrestore: check for compatible xfsrestore, wkendall Re: [PATCH v3 9/9] xfsrestore: check for compatible xfsrestore, Christoph Hellwig Re: [PATCH v3 9/9] xfsrestore: check for compatible xfsrestore, Bill Kendall Re: [PATCH v3 9/9] xfsrestore: check for compatible xfsrestore, Christoph Hellwig [PATCH v3 8/9] xfsrestore: remove nix_t, wkendall Re: [PATCH v3 8/9] xfsrestore: remove nix_t, Christoph Hellwig [PATCH v3 7/9] xfsrestore: make node lookup more efficient, wkendall Re: [PATCH v3 7/9] xfsrestore: make node lookup more efficient, Alex Elder [PATCH v3 1/9] xfsrestore: turn off NODECHK, wkendall Re: [PATCH v3 1/9] xfsrestore: turn off NODECHK, Christoph Hellwig <= [PATCH v3 2/9] xfsrestore: change nrh_t from 32 to 64 bits, wkendall Re: [PATCH v3 2/9] xfsrestore: change nrh_t from 32 to 64 bits, Christoph Hellwig [PATCH v3 3/9] xfsrestore: cache path lookups, wkendall Re: [PATCH v3 3/9] xfsrestore: cache path lookups, Christoph Hellwig [PATCH v3 6/9] xfsrestore: fix node table setup, wkendall Re: [PATCH v3 0/9] xfsrestore dirent limitations and scaling issues, Alex Elder

Previous by Date:	Re: [PATCH] xfstests: check block truncation after write failure, Christoph Hellwig
Next by Date:	Re: [PATCH, RFC] xfs: fix failed write handling, Christoph Hellwig
Previous by Thread:	[PATCH v3 1/9] xfsrestore: turn off NODECHK, wkendall
Next by Thread:	[PATCH v3 2/9] xfsrestore: change nrh_t from 32 to 64 bits, wkendall
Indexes:	[Date] [Thread] [Top] [All Lists]