Re: [PATCH] xfstests: add _require_sparse_files

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Tue, Nov 09, 2010 at 06:34:54AM -0500, Christoph Hellwig wrote:
> updated version to also include test 239 which reqires the check, too.
> 
> ---
> From: Christoph Hellwig <hch@xxxxxx>
> Subject: [PATCH] xfstests: add _require_sparse_files
> 
> Add a helper to check if the filesystem supports sparse files.  This is
> used to guard tests that exercise sparse file functionality and would
> take forever on filesystems that have to zero all blocks on extending
> truncates.
> 
> Unfortunately there's no good way to autodetect this functionality, so
> just implement it as a blacklist for now.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks ok, minor typo needs fixing, but:

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

> +#
> +# Check if the filesystem supports sparese files.
                                      sparse

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx