Re: [PATCH] xfs: force background CIL push under sustained load

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Sep 23, 2010 at 12:27:43PM +1000, Dave Chinner wrote:
> The fix is to start blocking background pushes once the threshold has been
> exceeded by 50%. This is still only 37.5% of log space at worst, so keeps us
> well short of the limit a transaction must not exceed.


Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> + * the background push threshold to 1/8th (12.5%) the size of the log, and 
> then start

if you can please shorten this line a bit for the final version.