Re: [PATCH 1/2] dio: track and serialise unaligned direct IO

xfs

Re: [PATCH 1/2] dio: track and serialise unaligned direct IO

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 1/2] dio: track and serialise unaligned direct IO
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 2 Aug 2010 05:30:24 -0400
Cc:	linux-fsdevel@xxxxxxxxxxxxxxx, sandeen@xxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to:	<1280733945-16231-2-git-send-email-david@xxxxxxxxxxxxx>
References:	<1280733945-16231-1-git-send-email-david@xxxxxxxxxxxxx> <1280733945-16231-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-08-17)

> +DEFINE_SPINLOCK(dio_zero_block_lock);
> +LIST_HEAD(dio_zero_block_list);

These two should be static.

Otherwise looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/2] dio: serialise unaligned direct IO V2, Dave Chinner [PATCH 2/2] dio: scale unaligned IO tracking via multiple lists, Dave Chinner Re: [PATCH 2/2] dio: scale unaligned IO tracking via multiple lists, Christoph Hellwig [PATCH 1/2] dio: track and serialise unaligned direct IO, Dave Chinner Re: [PATCH 1/2] dio: track and serialise unaligned direct IO, Christoph Hellwig <= Re: [PATCH 1/2] dio: track and serialise unaligned direct IO, Jan Kara

Previous by Date:	[PATCH 1/2] dio: track and serialise unaligned direct IO, Dave Chinner
Next by Date:	Re: [PATCH 2/2] dio: scale unaligned IO tracking via multiple lists, Christoph Hellwig
Previous by Thread:	[PATCH 1/2] dio: track and serialise unaligned direct IO, Dave Chinner
Next by Thread:	Re: [PATCH 1/2] dio: track and serialise unaligned direct IO, Jan Kara
Indexes:	[Date] [Thread] [Top] [All Lists]