| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/5] xfs: fix xfs_trans_add_item() lockdep warnings |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 19 Jul 2010 10:24:56 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20100716051934.GC29915@xxxxxxxxxxxxx> |
| References: | <1279154300-2018-1-git-send-email-david@xxxxxxxxxxxxx> <1279154300-2018-4-git-send-email-david@xxxxxxxxxxxxx> <20100716051934.GC29915@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Fri, Jul 16, 2010 at 01:19:34AM -0400, Christoph Hellwig wrote: > > - lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP); > > + lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP|KM_NOFS); > > KM_NOFS by itself actually is sufficiant. If you want to keep the > KM_SLEEP for documentation purposes at least add some spaces to make > it more redable. > > lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP | KM_NOFS); Will do. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/5] xfs: track AGs with reclaimable inodes in per-ag radix tree, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 0/5] xfs: reclaim bug fixes, Dave Chinner |
| Previous by Thread: | Re: [PATCH 3/5] xfs: fix xfs_trans_add_item() lockdep warnings, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 0/5] xfs: reclaim bug fixes, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |