xfs
[Top] [All Lists]

Re: [PATCH 5/5] xfs: fix memory reclaim recursion deadlock on locked ino

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/5] xfs: fix memory reclaim recursion deadlock on locked inode buffer
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 16 Jul 2010 01:22:27 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1279154300-2018-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1279154300-2018-1-git-send-email-david@xxxxxxxxxxxxx> <1279154300-2018-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Thu, Jul 15, 2010 at 10:38:20AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Calling into memory reclaim with a locked inode buffer can deadlock
> if memory reclaim tries to lock the inode buffer during inode
> teardown. Convert the relevant memory allocations to use KM_NOFS to
> avoid this deadlock condition.

Looks good, although the same style nitpicks as for patch 3 apply.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>