Re: [PATCH 1/2] xfs: don't block on buffer read errors

xfs

Re: [PATCH 1/2] xfs: don't block on buffer read errors

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 1/2] xfs: don't block on buffer read errors
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 14 Jul 2010 14:28:36 -0400
Cc:	xfs@xxxxxxxxxxx, axboe@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to:	<1279007450-10457-2-git-send-email-david@xxxxxxxxxxxxx>
References:	<1279007450-10457-1-git-send-email-david@xxxxxxxxxxxxx> <1279007450-10457-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-08-17)

Looks good, except that I'd rework the snipplet below

>       status = xfs_buf_iorequest(bp);
> -     if (!status && !(flags & XBF_ASYNC))
> +     if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)))
>               status = xfs_buf_iowait(bp);
>       return status;

as:

        if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))
                return status;
        return xfs_buf_iowait(bp);

to make it a bit more clear.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/2] Graceful failures for XFS on an unconfigured loop device, Dave Chinner [PATCH 1/2] xfs: don't block on buffer read errors, Dave Chinner Re: [PATCH 1/2] xfs: don't block on buffer read errors, Christoph Hellwig <= Re: [PATCH 1/2] xfs: don't block on buffer read errors, Dave Chinner [PATCH 2/2] blkdev: check for valid request queue before issuing flush, Dave Chinner Re: [PATCH 2/2] blkdev: check for valid request queue before issuing flush, Jens Axboe

Previous by Date:	Gold Bullion/Dore Sale Information, Benjamin Gold & Associates
Next by Date:	[PATCH] XFS: _xfs_buf_find ignores XBF_DONT_BLOCK flag, Peter Watkins
Previous by Thread:	[PATCH 1/2] xfs: don't block on buffer read errors, Dave Chinner
Next by Thread:	Re: [PATCH 1/2] xfs: don't block on buffer read errors, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]