Re: [PATCH] xfs: remove incorrect log write optimization

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Sun, Jul 11, 2010 at 10:30:00PM -0500, Alex Elder wrote:
> On Mon, 2010-06-28 at 10:34 -0400, Christoph Hellwig wrote:
> > We do need a barrier for the first buffer of a split log write.  Otherwise
> > we might incorrectly stamp the tail LSN into transactions in the first
> > block, or not flush data I/O before updating the inode size.
> 
> I'm not sure whether "first block" means the one at the beginning
> of the log, or the one at the beginning of a split log write.

It means beginning of the split write.  I can fix up the commit message
if you want.