| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: unregister inode shrinker before freeing filesystem structures V2 |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 12 Jul 2010 11:05:31 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1278916858-24903-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1278916858-24903-1-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-08-17) |
On Mon, Jul 12, 2010 at 04:40:58PM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Currently we don't remove the XFS mount from the shrinker list until late in > the unmount path. By this time, we have already torn down the internals of the > filesystem (e.g. the per-ag structures), and hence if the shrinker is executed > between the teardown and the unregistering, the shrinker will get NULL per-ag > structure pointers and panic trying to dereference them. > > Fix this by removing the xfs mount from the shrinker list before tearing down > it's internal structures. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > --- Looks good Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Slow delete, Michael Monnerie |
|---|---|
| Next by Date: | Re: [PATCH] xfs: remove incorrect log write optimization, Christoph Hellwig |
| Previous by Thread: | [PATCH] xfs: unregister inode shrinker before freeing filesystem structures V2, Dave Chinner |
| Next by Thread: | XFS status update for June 2010, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |