Re: [PATCH] Check block magic number so we scan only valid blocks.

xfs

Re: [PATCH] Check block magic number so we scan only valid blocks.

To:	Peter Watkins <treestem@xxxxxxxxx>
Subject:	Re: [PATCH] Check block magic number so we scan only valid blocks.
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 7 Jul 2010 19:52:18 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1278515351-24928-1-git-send-email-treestem@xxxxxxxxx>
References:	<1278515351-24928-1-git-send-email-treestem@xxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-08-17)

On Wed, Jul 07, 2010 at 11:09:11AM -0400, Peter Watkins wrote:
> Hello,
> 
> Occasionally I've hit a SEGV while querying free space in xfs_db on a mounted
> file system. In scanfunc_bno, block->bb_numrecs has crazy values. And 
> bb_magic 
> is not XFS_ABTB_MAGIC.
> 
> Does a check like this, similiar to other places, make sense?

Yes, it's reasonable.  As long as you'd don't expect directly poking at
a life partition giving correct results..


> Should scanfunc_cnt make a similiar check?

Yes.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Check block magic number so we scan only valid blocks., Peter Watkins Re: [PATCH] Check block magic number so we scan only valid blocks., Christoph Hellwig <= [PATCH] Check block magic number so we scan only valid blocks., Peter Watkins

Previous by Date:	Re: utf-8' chars from Winxp machine may be problem related (was Re: xfs file system in process of becoming corrupt; though xfs_repair...), Stan Hoeppner
Next by Date:	Re: utf-8' chars from Winxp machine may be problem related (was Re: xfs file system in process of becoming corrupt; though xfs_repair...), Linda A. Walsh
Previous by Thread:	[PATCH] Check block magic number so we scan only valid blocks., Peter Watkins
Next by Thread:	[PATCH] Check block magic number so we scan only valid blocks., Peter Watkins
Indexes:	[Date] [Thread] [Top] [All Lists]