Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused stateme

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings
From:	Andi Kleen <andi@xxxxxxxxxxxxxx>
Date:	Fri, 11 Jun 2010 18:36:44 +0200
Cc:	Andi Kleen <andi@xxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to:	<20100611162007.GC7556@xxxxxxxxxxxxx>
References:	<20100610110.764742110@xxxxxxxxxxxxxx> <20100610111052.3DDC5B1A2B@xxxxxxxxxxxxxxxxxxxx> <20100611162007.GC7556@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.17 (2007-11-01)

On Fri, Jun 11, 2010 at 12:20:07PM -0400, Christoph Hellwig wrote:
> Most of this looks good to me, but I really don't like the QASSERT
> macro.  If you're fine with it I'll split this up into smaller patches

Why do you not like it? 

The alternative will be likely uglier.

> and resubmit the unmodified parts under your name and redo those bits
> I don't like.

Fine for me.

-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Christoph Hellwig Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen <= Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Dave Chinner Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Dave Chinner Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Dave Chinner Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Christoph Hellwig Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen

Previous by Date:	Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Christoph Hellwig
Next by Date:	Re: linux-2.6.34 xfs crash: xfs_inode_ag_iterator+0x6c - NULL pointer dereference, Peter Niemayer
Previous by Thread:	Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Christoph Hellwig
Next by Thread:	Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]