This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".
The branch, master has been updated
fb3b504 xfs: fix access to upper inodes without inode64
9b98b6f xfs: fix might_sleep() warning when initialising per-ag tree
38e712a fs/xfs/quota: Add missing mutex_unlock
3bd0946 xfs: remove duplicated #include
f8adb4d xfs: convert more trace events to DEFINE_EVENT
292ec4c xfs: xfs_trace.c: remove duplicated #include
07f1a4f xfs: Check new inode size is OK before preallocating
fdc07f4 xfs: clean up xlog_align
025101d xfs: cleanup log reservation calculactions
32891b2 xfs: be more explicit if RT mount fails due to config
657a4cf xfs: replace E2BIG with EFBIG where appropriate
from ccf7c23fc129e75ef60e6f59f60a485b7a056598 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit fb3b504adeee942e55393396fea8fdf406acf037
Author: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri May 28 19:03:10 2010 +0000
xfs: fix access to upper inodes without inode64
If a filesystem is mounted without the inode64 mount option we
should still be able to access inodes not fitting into 32 bits, just
not created new ones. For this to work we need to make sure the
inode cache radix tree is initialized for all allocation groups, not
just those we plan to allocate inodes from. This patch makes sure
we initialize the inode cache radix tree for all allocation groups,
and also cleans xfs_initialize_perag up a bit to separate the
inode32 logical from the general perag structure setup.
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
commit 9b98b6f3e1534bba2efcd5b16318945cf2218d99
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date: Thu May 27 01:58:13 2010 +0000
xfs: fix might_sleep() warning when initialising per-ag tree
The use of radix_tree_preload() only works if the radix tree was
initialised without the __GFP_WAIT flag. The per-ag tree uses
GFP_NOFS, so does not trigger allocation of new tree nodes from the
preloaded array. Hence it enters the allocator with a spinlock held
and triggers the might_sleep() warnings.
Reported-by; Chris Mason <chris.mason@xxxxxxxxxx>
Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
commit 38e712ab3d28d79725eaade02fe8aba51abac196
Author: Julia Lawall <julia@xxxxxxx>
Date: Wed May 26 15:57:23 2010 +0000
fs/xfs/quota: Add missing mutex_unlock
Add a mutex_unlock missing on the error path. The use of this lock
is balanced elsewhere in the file.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression E1;
@@
* mutex_lock(E1,...);
<+... when != E1
if (...) {
... when != E1
* return ...;
}
...+>
* mutex_unlock(E1,...);
// </smpl>
Signed-off-by: Julia Lawall <julia@xxxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
commit 3bd0946eb157e26240ca858d1a42738b095dc6f3
Author: Huang Weiyi <weiyi.huang@xxxxxxxxx>
Date: Tue May 25 22:15:26 2010 +0000
xfs: remove duplicated #include
Remove duplicated #include('s) in
fs/xfs/linux-2.6/xfs_quotaops.c
Signed-off-by: Huang Weiyi <weiyi.huang@xxxxxxxxx>
Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
commit f8adb4d574cf8c67f8391367136edc5469258fdc
Author: Li Zefan <lizf@xxxxxxxxxxxxxx>
Date: Mon May 24 08:25:57 2010 +0000
xfs: convert more trace events to DEFINE_EVENT
Use DECLARE_EVENT_CLASS, and save ~15K:
text data bss dec hex filename
171949 43028 48 215025 347f1 fs/xfs/linux-2.6/xfs_trace.o.orig
156521 43028 36 199585 30ba1 fs/xfs/linux-2.6/xfs_trace.o
No change in functionality.
Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
commit 292ec4cf3536a5ed8809e8823341b203e497bbaf
Author: Huang Weiyi <weiyi.huang@xxxxxxxxx>
Date: Sat May 22 17:13:20 2010 +0000
xfs: xfs_trace.c: remove duplicated #include
Remove duplicated #include('s) in
fs/xfs/linux-2.6/xfs_trace.c
Signed-off-by: Huang Weiyi <weiyi.huang@xxxxxxxxx>
Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
commit 07f1a4f5e89cd4e6c79d67d41e8a18c451214ae2
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date: Fri May 21 05:47:59 2010 +0000
xfs: Check new inode size is OK before preallocating
The new xfsqa test 228 tries to preallocate more space than the
filesystem contains. it should fail, but instead triggers an assert
about lock flags. The failure is due to the size extension failing
in vmtruncate() due to rlimit being set. Check this before we start
the preallocation to avoid allocating space that will never be used.
Also the path through xfs_vn_allocate already holds the IO lock, so
it should not be present in the lock flags when the setattr fails.
Hence the assert needs to take this into account. This will prevent
other such callers from hitting this incorrect ASSERT.
(Fixed a reference to "newsize" to read "new_size". -Alex)
Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
commit fdc07f44c891d3fdee7722a03e3881614a293b3c
Author: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon May 10 17:28:14 2010 +0000
xfs: clean up xlog_align
Add suggested cleanups to commit 29db3370a1369541d58d692fbfb168b8a0bd7f41
from review that didn't end up being commited.
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
commit 025101dca4480eff9da948405e872d5115030850
Author: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue May 4 13:53:48 2010 +0000
xfs: cleanup log reservation calculactions
Instead of having small helper functions calling big macros do the
calculations for the log reservations directly in the functions.
These are mostly 1:1 from the macros execept that the macros kept
the quota calculations in their callers.
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
commit 32891b292d6262d1db8e553cf3f4b38a91247b5a
Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri Apr 30 16:43:48 2010 +0000
xfs: be more explicit if RT mount fails due to config
Recent testers were slightly confused that a realtime mount failed
due to missing CONFIG_XFS_RT; we can make that a little more
obvious.
V2: drop the else as suggested by Christoph
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
commit 657a4cffde065beca7d919e867f61e7d322708b6
Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri Apr 30 03:42:49 2010 +0000
xfs: replace E2BIG with EFBIG where appropriate
Many places in the xfs code return E2BIG when they really mean
EFBIG; trying to grow past 16T on a 32 bit machine, for example,
says "Argument list too long" rather than "File too large" which is
not particularly helpful.
Some of these don't make perfect sense as EFBIG either, but still
better than E2BIG IMHO.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Alex Elder <aelder@xxxxxxx>
-----------------------------------------------------------------------
Summary of changes:
fs/xfs/linux-2.6/xfs_iops.c | 16 ++-
fs/xfs/linux-2.6/xfs_quotaops.c | 1 -
fs/xfs/linux-2.6/xfs_sync.c | 9 -
fs/xfs/linux-2.6/xfs_trace.c | 1 -
fs/xfs/linux-2.6/xfs_trace.h | 356 ++++++++++++++++---------------
fs/xfs/quota/xfs_qm.c | 4 +-
fs/xfs/xfs_ag.h | 1 -
fs/xfs/xfs_iget.c | 3 -
fs/xfs/xfs_inode.c | 2 -
fs/xfs/xfs_log_recover.c | 11 +-
fs/xfs/xfs_mount.c | 68 +++----
fs/xfs/xfs_rtalloc.c | 4 +-
fs/xfs/xfs_rtalloc.h | 11 +-
fs/xfs/xfs_trans.c | 446 +++++++++++++++++++++++++++++++++++----
fs/xfs/xfs_trans.h | 411 ------------------------------------
fs/xfs/xfs_vnodeops.c | 2 +-
16 files changed, 649 insertions(+), 697 deletions(-)
hooks/post-receive
--
XFS development tree
|