Re: [PATCH 12/12] xfs: Ensure inode allocation buffers are fully replaye

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 12/12] xfs: Ensure inode allocation buffers are fully replayed
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 10 May 2010 13:43:12 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1273210860-23414-13-git-send-email-david@xxxxxxxxxxxxx>
References:	<1273210860-23414-1-git-send-email-david@xxxxxxxxxxxxx> <1273210860-23414-13-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.19 (2009-01-05)

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>


> Also, move an assert in the buffer release path outside the hash
> spinlock so that if the assert is hit the system continues to run in
> a debuggable state.

But this really should be a separate patch.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/12] xfs: delayed logging V5, Dave Chinner [PATCH 01/12] xfs: Don't reuse the same transaction ID for duplicated transactions., Dave Chinner [PATCH 05/12] xfs: clean up log ticket overrun debug output, Dave Chinner [PATCH 06/12] xfs: make the log ticket ID available outside the log infrastructure, Dave Chinner Re: [PATCH 06/12] xfs: make the log ticket ID available outside the log infrastructure, Christoph Hellwig [PATCH 02/12] xfs: allow log ticket allocation to take allocation flags, Dave Chinner *[PATCH 04/12] xfs: Clean up XFS_BLI_ flag namespace*, Dave Chinner* [PATCH 11/12] xfs: enable background pushing of the CIL, Dave Chinner Re: [PATCH 11/12] xfs: enable background pushing of the CIL, Christoph Hellwig [PATCH 12/12] xfs: Ensure inode allocation buffers are fully replayed, Dave Chinner Re: [PATCH 12/12] xfs: Ensure inode allocation buffers are fully replayed, Christoph Hellwig <= [PATCH 10/12] xfs: forced unmounts need to push the CIL, Dave Chinner Re: [PATCH 10/12] xfs: forced unmounts need to push the CIL, Christoph Hellwig [PATCH 07/12] xfs: Improve scalability of busy extent tracking, Dave Chinner Re: [PATCH 07/12] xfs: Improve scalability of busy extent tracking, Christoph Hellwig [PATCH 08/12] xfs: Delayed logging design documentation, Dave Chinner [PATCH 03/12] xfs: modify buffer item reference counting, Dave Chinner [PATCH 09/12] xfs: Introduce delayed logging core code, Dave Chinner Re: [PATCH 09/12] xfs: Introduce delayed logging core code, Christoph Hellwig Re: [PATCH 09/12] xfs: Introduce delayed logging core code, Dave Chinner Re: [PATCH 09/12] xfs: Introduce delayed logging core code, Dave Chinner

Previous by Date:	Re: [PATCH] xfstests: test extent size hints, Geoffrey Wehrman
Next by Date:	Re: bad primary superblock - bad magic number !!!, Leo Davis
Previous by Thread:	[PATCH 12/12] xfs: Ensure inode allocation buffers are fully replayed, Dave Chinner
Next by Thread:	[PATCH 10/12] xfs: forced unmounts need to push the CIL, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]