On Wed, Apr 28, 2010 at 08:28:50AM -0400, Christoph Hellwig wrote:
> This series gets rid of the xfs_iomap structure which we use to
> communicate between xfs_aops.c and xfs_iomap.c. It's not a very
> useful structure - we basically need block offsets above and below
> it, but it's in terms of bytes. Removing it and using the xfs_bmbt_irec
> structure instead thus simplifies the code and reduces the stack footprint
> of the writeback code.
I like the idea - anything we can remove from the writeback path is
useful in terms of stack footprint. I've had a quick look over the
patches and can't see any obvious issues, but I need to do a more
in-depth review of them over the next couple of days. In the mean
time, I'll add them to my QA stack...
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|