Re: [PATCH 5/7] xfs: encapsulate bbcount validity checking

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Mar 18, 2010 at 05:54:06PM -0500, Alex Elder wrote:
> This replaces is a duplicated block of essentially identical code
> in three spots with a call to a common helper routine.

I don't think I really like this.  It's adding a lot of indirections
for some simple error reporting.

> +     if (bbcount > 0 && bbcount <= log->l_logBBsize)
> +             return 1;

Adding a tiny helper just for this might be worthwhile, though.