Re: [PATCH 6/8] xfs: remove duplicate code from dquot reclaim

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 6/8] xfs: remove duplicate code from dquot reclaim
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sat, 3 Apr 2010 06:00:11 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1270125691-29266-7-git-send-email-david@xxxxxxxxxxxxx>
References:	<1270125691-29266-1-git-send-email-david@xxxxxxxxxxxxx> <1270125691-29266-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.19 (2009-01-05)

On Thu, Apr 01, 2010 at 11:41:29PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The dquot shaker and the free-list reclaim code use exactly the same
> algorithm but the code is duplicated and slightly different in each
> case. Make the shaker code use the single dquot reclaim code to
> remove the code duplication.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 4/8] xfs: add log item recovery tracing, (continued) Re: [PATCH 4/8] xfs: add log item recovery tracing, Christoph Hellwig Re: [PATCH 4/8] xfs: add log item recovery tracing, Dave Chinner [PATCH 1/8] xfs: ensure that sync updates the log tail correctly, Dave Chinner Re: [PATCH 1/8] xfs: ensure that sync updates the log tail correctly, Christoph Hellwig Re: [PATCH 1/8] xfs: ensure that sync updates the log tail correctly, Alex Elder [PATCH 7/8] xfs: convert the dquot hash list to use list heads, Dave Chinner Re: [PATCH 7/8] xfs: convert the dquot hash list to use list heads, Christoph Hellwig [PATCH 8/8] xfs: convert the dquot free list to use list heads, Dave Chinner Re: [PATCH 8/8] xfs: convert the dquot free list to use list heads, Christoph Hellwig [PATCH 6/8] xfs: remove duplicate code from dquot reclaim, Dave Chinner Re: [PATCH 6/8] xfs: remove duplicate code from dquot reclaim, Christoph Hellwig <= [PATCH 3/8] xfs: make the log ticket transaction id random, Dave Chinner Re: [PATCH 3/8] xfs: make the log ticket transaction id random, Christoph Hellwig Re: [PATCH 3/8] xfs: make the log ticket transaction id random, Dave Chinner Re: [PATCH 3/8] xfs: make the log ticket transaction id random, Christoph Hellwig [PATCH 5/8] xfs: convert the per-mount dquot list to use list heads, Dave Chinner Re: [PATCH 5/8] xfs: convert the per-mount dquot list to use list heads, Christoph Hellwig [PATCH 9/8] xfs: remove xfs_dqmarker, Christoph Hellwig Re: [PATCH 9/8] xfs: remove xfs_dqmarker, Dave Chinner

Previous by Date:	Re: [PATCH 5/8] xfs: convert the per-mount dquot list to use list heads, Christoph Hellwig
Next by Date:	Re: [PATCH 7/8] xfs: convert the dquot hash list to use list heads, Christoph Hellwig
Previous by Thread:	[PATCH 6/8] xfs: remove duplicate code from dquot reclaim, Dave Chinner
Next by Thread:	[PATCH 3/8] xfs: make the log ticket transaction id random, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]