On Thu, Mar 18, 2010 at 03:13:10PM +0100, Jan Engelhardt wrote:
>
> On Monday 2010-03-08 02:28, Dave Chinner wrote:
> >
> >Looks ok, but a couple of things. First, it would be good if you
> >supplied a reason/justification for the patch so the commit message
> >will tell us why this change was made.
> >
> >Please keep the same indent style as the rest of the functions. i.e
>
> >> xfsaild_start(
> >> - struct xfs_ail *ailp)
> >> + struct xfs_ail *ailp,
> >> + const char *fsname)
> >> {
> >> ailp->xa_target = 0;
> >> - ailp->xa_task = kthread_run(xfsaild, ailp, "xfsaild");
> >> + ailp->xa_task = kthread_run(xfsaild, ailp, "xfsaild/%s", fsname);
> >
> >No need to pass the name into this function. It can be retrieved
> >from ailp->xa_mount->m_fsname.
>
> I think I've got that now.
>
> N.B.: The xfslogd/N threads are obvious (percpu workqueue, or
> whatever the tech is currently called), but at one time in the
> past it struck me that I had lots of xfsbufd/aild/syncd without
> the /n suffix.
Looks good now, I'll queue it up with all the other pending changes
I have.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|