| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/9] xfs: factor log item initialisation |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sat, 6 Mar 2010 05:51:39 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1267840284-4652-2-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1267840284-4652-1-git-send-email-david@xxxxxxxxxxxxx> <1267840284-4652-2-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Sat, Mar 06, 2010 at 12:51:16PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Each log item type does manual initialisation of the log item. > Delayed logging introduce?? new fields that need initialisation, so > factor all the open coded initialisation into a common function > first. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good. While not really an obvious cleanup by itself I see where it comes in useful later. Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH] [RFC] xfs_fsr: Improve handling of attribute forks, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/9] xfs: Add inode pin counts to traces, Christoph Hellwig |
| Previous by Thread: | [PATCH 1/9] xfs: factor log item initialisation, Dave Chinner |
| Next by Thread: | [PATCH 9/9] xfs: factor xlog_write and make use of new log vector structure, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |