| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH for-2.6.33] xfs: flush all log buffers in xlog_dealloc_log |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 4 Feb 2010 19:14:22 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20100203105545.GA1047@xxxxxxxxxxxxx> |
| References: | <20100201220813.GA3519@xxxxxxxxxxxxx> <20100203105545.GA1047@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Wed, Feb 03, 2010 at 05:55:45AM -0500, Christoph Hellwig wrote: > Actually I'll take this one back - the log buffers aren't delwri > so xfs_flush_buftarg probably only helped by timing or the > xfs_buf_runall_queues on xfslogd_workqueue. Need to think about > this a bit more. Can you point me at the bug report? IIRC I've seen this in the past where we freed the log before we've done all the correct shutdown processing and they got fixed by correcting the order of shutdown to ensure the log is idle before freeing it... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 08/10] xfs: move the inode locking outside xfs_fsync(), Dave Chinner |
|---|---|
| Next by Date: | re-enabling quota enforcement => invalid argument, Jan Schulze |
| Previous by Thread: | Re: [PATCH for-2.6.33] xfs: flush all log buffers in xlog_dealloc_log, Christoph Hellwig |
| Next by Thread: | Re: [PATCH for-2.6.33] xfs: flush all log buffers in xlog_dealloc_log, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |