| To: | Alex Elder <aelder@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: fix format string warnings in locktest.c |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 21 Jan 2010 12:32:37 -0500 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <1AB9A794DBDDF54A8A81BE2296F7BDFE012A69AE@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <1AB9A794DBDDF54A8A81BE2296F7BDFE012A69AC@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <1AB9A794DBDDF54A8A81BE2296F7BDFE012A69AE@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Thu, Jan 21, 2010 at 10:34:12AM -0600, Alex Elder wrote: > Alex Elder wrote: > > Christoph Hellwig wrote: > >> Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > Looks good. > > > > Reviewed-by: Alex Elder <aelder@xxxxxxx> > > By the way, the content of this patch is already incorporated > in Dave's patch "[7/8] xfstests: fix printf warnings in loctest.c". > http://patchwork.xfs.org/patch/517/ Dave fixed the warnings not quite correctly, he switched from %d which was totally wrong to %lu which is only correct on some 64-bit architectures. %zd is the really correct format. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [PATCH] xfstests: fix format string warnings in locktest.c, Alex Elder |
|---|---|
| Next by Date: | RE: [PATCH] xfstests: fix format string warnings in locktest.c, Alex Elder |
| Previous by Thread: | RE: [PATCH] xfstests: fix format string warnings in locktest.c, Alex Elder |
| Next by Thread: | RE: [PATCH] xfstests: fix format string warnings in locktest.c, Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |