Re: [PATCH 2/8] xfs: convert DM ops to use unsigned char names

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 2/8] xfs: convert DM ops to use unsigned char names
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 19 Jan 2010 04:25:07 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1263861026-13448-3-git-send-email-david@xxxxxxxxxxxxx>
References:	<1263861026-13448-1-git-send-email-david@xxxxxxxxxxxxx> <1263861026-13448-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.19 (2009-01-05)

On Tue, Jan 19, 2010 at 11:30:20AM +1100, Dave Chinner wrote:
> dmops uses a signed char for it's namespace event. To be consistent
> with the rest of the code, convert them to unsigned char for the
> namespace string.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

possibly we should just get rid of the dm hooks now that they've been
dead for years..

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/8] xfs: clean up pointer sign differences, Dave Chinner [PATCH 8/8] xfs: make compile warn about char sign mismatches again, Dave Chinner Re: [PATCH 8/8] xfs: make compile warn about char sign mismatches again, Christoph Hellwig Re: [PATCH 8/8] xfs: make compile warn about char sign mismatches again, Dave Chinner [PATCH 4/8] xfs: make xfs_dir_cilookup_result use unsigned char, Dave Chinner Re: [PATCH 4/8] xfs: make xfs_dir_cilookup_result use unsigned char, Christoph Hellwig [PATCH 7/8] xfs: clean up sign warnings in dir2 code, Dave Chinner Re: [PATCH 7/8] xfs: clean up sign warnings in dir2 code, Christoph Hellwig [PATCH 2/8] xfs: convert DM ops to use unsigned char names, Dave Chinner Re: [PATCH 2/8] xfs: convert DM ops to use unsigned char names, Christoph Hellwig <= [PATCH 6/8] xfs: convert attr to use unsigned names, Dave Chinner Re: [PATCH 6/8] xfs: convert attr to use unsigned names, Christoph Hellwig [PATCH 3/8] xfs: convert dirnameops to unsigned char names, Dave Chinner Re: [PATCH 3/8] xfs: convert dirnameops to unsigned char names, Christoph Hellwig [PATCH 5/8] xfs: xfs_buf_iomove() doesn't care about signedness, Dave Chinner Re: [PATCH 5/8] xfs: xfs_buf_iomove() doesn't care about signedness, Christoph Hellwig [PATCH 1/8] xfs: directory names are unsigned, Dave Chinner Re: [PATCH 1/8] xfs: directory names are unsigned, Christoph Hellwig

Previous by Date:	Re: [PATCH 1/8] xfs: directory names are unsigned, Christoph Hellwig
Next by Date:	Re: [PATCH 3/8] xfs: convert dirnameops to unsigned char names, Christoph Hellwig
Previous by Thread:	[PATCH 2/8] xfs: convert DM ops to use unsigned char names, Dave Chinner
Next by Thread:	[PATCH 6/8] xfs: convert attr to use unsigned names, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]